fix: Error when upgrading pnpm to latest in devEngines.packageManager - #880
Open
thiagobarbosa wants to merge 1 commit into
Open
fix: Error when upgrading pnpm to latest in devEngines.packageManager#880thiagobarbosa wants to merge 1 commit into
thiagobarbosa wants to merge 1 commit into
Conversation
Signed-off-by: Thiago Barbosa <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874
Problem
When a project pins an exact version in
devEngines.packageManagerand has no packageManagerfield, running corepack use @ fails with a confusing error, because
Corepack compares the new version against the pinned devEngines range instead of just
updating it.
Changes
When
devEngines.packageManageris the only source of truth (nopackageManagerfield, samepackage manager name, and an exact version), update
devEngines.packageManager.versioninplace instead of validating against it and adding a separate
packageManagerfield.Tests
Added a test in
tests/Use.test.tsreproducing the issue: it pinsdevEngines.packageManager.versionto2.1.0, runsuse [email protected], and asserts thedevEnginesversion is bumped while nopackageManagerfield is added.